When doing pr reviews, I often also shrug and think: “If it breaks, it’s not my mess to clean up.” Then click Aporoved.
lgtm
Spoiler alert: is own code 😔
I’m kind of bummed no one at my job really does code reviews seriously. I don’t really get any feedback, so it’s hard to improve.
That’s also probably why the older code is an idiosyncratic mess of mutations and "oh yeah you need this config file that’s not in source control " and “oh sorry I guess I hard coded that file path, huh?”
Exactly the same at my job. And it really shows in the code quality, or lack thereof. And then sometimes they wonder why it becomes more and more complicated to add new things. But most of the time they just think that it’s perfectly normal that way and are completely oblivious to all the ways it could be improved. I once talked to my boss about it and he basically replied with “Well you know, there just isn’t a code style that everybody likes, so there’s no reason to even try.”
