curl https://some-url | sh

I see this all over the place nowadays, even in communities that, I would think, should be security conscious. How is that safe? What’s stopping the downloaded script from wiping my home directory? If you use this, how can you feel comfortable?

I understand that we have the same problems with the installed application, even if it was downloaded and installed manually. But I feel the bar for making a mistake in a shell script is much lower than in whatever language the main application is written. Don’t we have something better than “sh” for this? Something with less power to do harm?

  • WolfLink@sh.itjust.works
    link
    fedilink
    arrow-up
    0
    ·
    edit-2
    4 months ago

    It isn’t more dangerous than running a binary downloaded from them by any other means. It isn’t more dangerous than downloaded installer programs common with Windows.

    TBH macOS has had the more secure idea of by default using sandboxes applications downloaded directly without any sort of installer. Linux is starting to head in that direction now with things like Flatpak.

  • Artyom@lemm.ee
    link
    fedilink
    arrow-up
    0
    ·
    4 months ago

    What’s stopping the downloaded script from wiping my home directory?

    What’s stopping any Makefile, build script, or executable from running rm -rf ~? The correct answer is “nothing”. PPAs are similarly open, things are a little safer if you only use your distro’s default package sources, but it’s always possible that a program will want to be able to delete something in your home directory, so it always has permission.

    Containerized apps are the only way around this, where they get their own home directory.

      • brian@programming.dev
        link
        fedilink
        arrow-up
        0
        ·
        4 months ago

        plenty of package managers have.

        flatpak doesn’t require any admin to install a new app

        nixos doesn’t run any code at all on your machine for just adding a package assuming it’s already been cached. if it hasn’t been cached it’s run in a sandbox. the cases other package managers use post install configuration scripts for are a different mechanism which possibly has root access depending on what it is.

    • moonpiedumplings@programming.dev
      link
      fedilink
      arrow-up
      0
      ·
      4 months ago

      Docker doesn’t do this anymore. Their install script got moved to “only do this for testing”.

      Use a convenience script. Only recommended for testing and development environments.

      Now, their install page recommends packages/repos first, and then a manual install of the binaries second.

  • Richard@lemmy.world
    link
    fedilink
    English
    arrow-up
    0
    ·
    4 months ago

    Can you not just run the curl or wget without piping it into bash, first? This way you could inspect what the script wants to do.

  • nous@programming.dev
    link
    fedilink
    English
    arrow-up
    0
    ·
    4 months ago

    Most packages managers can run arbitrary code on install or upgrade or removal. You are trusting the code you choose to run on your system no matter where you get it from. Remember the old bug in ubuntu that ran a rm -rf / usr/.. instead of rm -rf /usr/... and wiped a load of peoples systems?

    Flatpacks, Apparmor and snaps are better in this reguard as they are somewhat more sandboxed and can restrict what the applications have access to.

    But really if the install script is from the authors of the package then it should be just as trustworthy as the package. But generally I download and read the install scripts as there is no standard they are following and I don’t want them touching random system files in ways I am not aware of or cannot undo easily. Sometimes they are just detecting the OS and picking relevant packages to install - maybe with some thrid party repos. Other times they mess with your home partition and do a bunch of stuff including messing with bashrc files to add things to your PATH which I don’t like. I would never run a install script that is not from the author of the application though and be very wary of install scripts from a smaller package with fewer users.

  • c10l@lemmy.world
    link
    fedilink
    arrow-up
    0
    ·
    4 months ago

    To answer the question, no - you’re not the only one. People have written and talked about this extensively.

    Personally, I think there’s a lot more nuance to the answer. Also a lot has been written about this.

    You mention “communities that are security conscious”. I’m not sure in which ways you feel this practice to be less secure than alternatives. I tend to be pretty security conscious, to the point of sometimes being annoying to my team mates. I still use this installation method a lot where it makes sense, without too much worry. I also skip it other times.

    Without knowing a bit more about your specific worries and for what kinds of threat you feel this technique is bad, it’s difficult to respond specifically.

    Feel is fine, and if you’re uncomfortable with something, the answer is generally to either avoid it (by reading the script and executing the relevant commands yourself, or by skipping using this software altogether, for instance), or to understand why you’re uncomfortable and rationally assess whether that feeling is based on reality or imagination - or to which degree of each.

    As usual, the real answer is - it depends.

    • cschreib@programming.devOP
      link
      fedilink
      arrow-up
      0
      ·
      4 months ago

      Thank you for the nuanced answer!

      You ask why I feel this is less secure: it seems the lowest possible bar when it comes to controlling what gets installed on your system. The script may or may not give you a choice as to where things get installed. It could refuse to install or silently overwrite stuff if something already exists. If install fails, it may or may not leave data behind, in directories I may or may not know about. It may or may not run a checksum on the downloaded data before installing. Because it’s a competely free-form script, there is no standard I can expect. For an application, I would read the documentation to learn more, but these scripts are not normally documented (other than “use this to install”). That uncertainty, to me, is insecure/unsafe.

  • esa@discuss.tchncs.de
    link
    fedilink
    arrow-up
    0
    ·
    4 months ago

    This is simpler than the download, ./configure, make, make install steps we had some decades ago, but not all that different in that you wind up with arbitrary, unmanaged stuff.

    Preferably use the distro native packages, or else their build system if it’s easily available (e.g. AUR in Arch)

  • zygo_histo_morpheus@programming.dev
    link
    fedilink
    arrow-up
    0
    ·
    4 months ago

    You have the option of piping it into a file instead, inspecting that file for yourself and then running it, or running it in some sandboxed environment. Ultimately though, if you are downloading software over the internet you have to place a certain amount of trust in the person your downloading the software from. Even if you’re absolutely sure that the download script doesn’t wipe your home directory, you’re going to have to run the program at some point and it could just as easily wipe your home directory at that point instead.

    • cschreib@programming.devOP
      link
      fedilink
      arrow-up
      0
      ·
      4 months ago

      Indeed, looking at the content of the script before running it is what I do if there is no alternative. But some of these scripts are awfully complex, and manually parsing the odd bash stuff is a pain, when all I want to know is : 1) what URL are you downloading stuff from? 2) where are you going to install the stuff?

      As for running the program, I would trust it more than a random deployment script. People usually place more emphasis on testing the former, not so much the latter.

    • rah@feddit.uk
      link
      fedilink
      English
      arrow-up
      0
      ·
      edit-2
      4 months ago

      You have the option of piping it into a file instead, inspecting that file for yourself and then running it, or running it in some sandboxed environment.

      That’s not what projects recommend though. Many recommend piping the output of an HTTP transfer over the public Internet directly into a shell interpreter. Even just

      curl https://... > install.sh; sh install.sh
      

      would be one step up. The absolute minimum recommendation IMHO should be

      curl https://... > install.sh; less install.sh; sh install.sh
      

      but this is still problematic.

      Ultimately, installing software is a labourious process which requires care, attention and the informed use of GPG. It shouldn’t be simplified for convenience.

      Also, FYI, the word “option” implies that I’m somehow restricted to a limited set of options in how I can use my GNU/Linux computer which is not the case.

      • zygo_histo_morpheus@programming.dev
        link
        fedilink
        arrow-up
        0
        ·
        4 months ago

        I mean if you think that it’s bad for linux culture because you’re teaching newbies the wrong lessons, fair enough.

        My point is that most people can parse that they’re essentially asking you to run some commands at a url, and if you have even a fairly basic grasp of linux it’s easy to do that in whatever way you want. I don’t know if I personally would be any happier if people took the time to lecture me on safety habits, because I can interpret the command for myself. curl https://some-url | sh is terse and to the point, and I know not to take it completely literally.

        • rah@feddit.uk
          link
          fedilink
          English
          arrow-up
          0
          ·
          4 months ago

          linux culture

          snigger

          you’re teaching newbies the wrong lessons

          The problem is not that it’s teaching bad lessons, it’s that it’s actually doing bad things.

          most people can parse that they’re essentially asking you to run some commands at a url

          I know not to take it completely literally

          Then it needn’t be written literally.

          I think you’re giving the authors of such installation instructions too much credit. I think they intend people to take it literally. I think this because I’ve argued with many of them.

      • gaylord_fartmaster@lemmy.world
        link
        fedilink
        arrow-up
        0
        ·
        4 months ago

        Showing people that are running curl piped to bash the script they are about to run doesn’t really accomplish anything. If they can read bash and want to review the script then they can by just opening the URL, and the people that aren’t doing that don’t care what’s in the script, so why waste their time with it?

        Do you think most users installing software from the AUR are actually reading the pkgbuilds? I’d guess it’s a pretty small percentage that do.

        • rah@feddit.uk
          link
          fedilink
          English
          arrow-up
          0
          ·
          edit-2
          4 months ago

          Showing people that are running curl piped to bash the script they are about to run doesn’t really accomplish anything. If they can read bash and want to review the script then they can by just opening the URL

          What it accomplishes is providing the instructions (i.e. an easily copy-and-pastable terminal command) for people to do exactly that.

          • gaylord_fartmaster@lemmy.world
            link
            fedilink
            arrow-up
            0
            ·
            4 months ago

            If you can’t review a bash script before running it without having an unnecessarily complex one-liner provided to you to do so, then it doesn’t matter because you aren’t going to be able to adequately review a bash script anyway.

            • rah@feddit.uk
              link
              fedilink
              English
              arrow-up
              0
              ·
              4 months ago

              If you can’t review a bash script before running it without having an unnecessarily complex one-liner provided to you

              Providing an easily copy-and-pastable one-liner does not imply that the reader could not themselves write such a one-liner.

              Having the capacity to write one’s own commands doesn’t imply that there is no value in having a command provided.

              unnecessarily complex

              LOL

              • gaylord_fartmaster@lemmy.world
                link
                fedilink
                arrow-up
                0
                ·
                4 months ago

                I don’t think you realize that if your goal is to have a simple install method anyone can use, even redirecting the output to install.sh like in your examples is enough added complexity to make it not work in some cases. Again, those are not made for people that know bash.

                • rah@feddit.uk
                  link
                  fedilink
                  English
                  arrow-up
                  0
                  ·
                  edit-2
                  4 months ago

                  even redirecting the output to install.sh like in your examples is enough added complexity to make it not work in some cases

                  You can’t have an install method that works in all cases.

                  if your goal is to have a simple install method anyone can use

                  Similarly, you can’t have an install method anyone can use.

  • SwizzleStick@lemmy.zip
    link
    fedilink
    English
    arrow-up
    0
    ·
    4 months ago

    It’s convenience over security, something that creeps in anywhere there is popularity. For those who just want x or y to work without needing to spend their day in the terminal - they’re great.

    You’d expect these kinds of script to be well tested against their targets and for the user to have/identify the correct target. Their sources should at least point out the security issue and advise to grab and inspect before straight up piping it though. Some I have seen do this.

    Running them like this means you put 100% trust in the author, the source and your DNS. Not a big ask for some. Unthinkable for others.